Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/remove command #483

Merged
merged 33 commits into from
Nov 28, 2023
Merged

Conversation

Wackyator
Copy link
Contributor

This adds a remove/rm subcommand to pixi which removes dependencies from the following tablles in the toml file:

  • [dependencies]
  • [host-dependencies]
  • [build-dependencies]
  • [target.{platform}.dependencies]
  • [target.{platform}.host-dependencies]
  • [target.{platform}.build-dependencies]

Closes #49

Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UX is really good, adding the updating of the prefix is a requirement from my point of view though.

src/cli/remove.rs Show resolved Hide resolved
src/project/manifest.rs Outdated Show resolved Hide resolved
src/project/manifest.rs Outdated Show resolved Hide resolved
src/project/mod.rs Outdated Show resolved Hide resolved
src/project/mod.rs Show resolved Hide resolved
ruben-arts and others added 10 commits November 22, 2023 22:10
Closes prefix-dev#485 

Helps user with:
```
➜ pixi run bla
bla: command not found

Available tasks:
        build
        build-docs
        docs
        install
        lint
        test
        test-all

➜ 
```

Allows user to:
```
➜ pixi run 'echo $PIXI_PACKAGE_VERSION'
0.7.1-dev

➜ pixi run 'echo $PIXI_PACKAGE_VERSION && echo $PIXI_PACKAGE_NAME && echo $CONDA_PREFIX'
0.7.1-dev
pixi
/home/rarts/development/pixi/.pixi/env
```



Depended on denoland/deno_task_shell#98
Fixes an issue where if you install `pyside6` you would get an error:

```
 × could not uninstall python package pyside6-6.6.0. Manually remove the `.pixi/env` folder and try again.
  ╰─▶ the RECORD file is missing
```
…ix-dev#494)

This PR adds support for checking the satisfiability of the lock-file
which includes pypi-dependencies.

Purls have been added to the lock-file
(conda/rattler#414) (See also:
conda/ceps#63). This enables checking
which conda packages will install which pypi packages without needing to
check the internet. This ensures we can still check if a lock-file is up
to date quickly.

I did not profile this code but I think there are a lot of places we can
improve the performance. Thats for a later PR.

I also didn't add tests. I think we should but we can also do that in
another PR.

Closes prefix-dev#467

---------

Co-authored-by: Ruben Arts <[email protected]>
@Wackyator Wackyator requested a review from ruben-arts November 27, 2023 14:29
src/cli/remove.rs Outdated Show resolved Hide resolved
src/cli/remove.rs Outdated Show resolved Hide resolved
src/project/mod.rs Outdated Show resolved Hide resolved
src/project/mod.rs Outdated Show resolved Hide resolved
@baszalmstra baszalmstra enabled auto-merge (squash) November 28, 2023 10:41
@baszalmstra baszalmstra merged commit 605f388 into prefix-dev:main Nov 28, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a remove command
3 participants